Remove CSS bootstrap dependency #15251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
flip1995
approved these changes
Jul 15, 2025
|
@flip1995 Did you have time to check it? :) |
|
Yes, here are my notes: All themes
New
Old
AyuContrast of top bar elements is bad. Also the symbols for collapse/expand all. New
Old
|
|
Seems like I forgot some cases, fixing that right away. |
GuillaumeGomez
force-pushed
the
rm-bootstrap
branch
from
778dcfb to
102e39f
Compare
|
Fixed! |
|
Thanks for the quick fix! |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #15208.
This PR removes the CSS
bootstrapdependency which contains 1504 CSS rules and weights 16.1 kB minified. Considering we used less than 50 of these rules, it's quite a waste.So this time, there are minor UI changes:
Before this PR:
With this PR:
With this, we will be able to go even further on reducing the page size next. =D
This time, the DOM size itself reduced a bit but the difference is too small to be noteworthy.
r? @samueltardieu
changelog: Remove CSS bootstrap dependency